Prep patches for --ex-lockfile-strict#2057
Prep patches for --ex-lockfile-strict#2057openshift-merge-robot merged 5 commits intocoreos:masterfrom
Conversation
Minor cosmetic change; rename the variables so they match the name of the options they represent.
jlebon
force-pushed
the
pr/strict-lockfile-prep
branch
from
8c857e1 to
84c78f1
Compare
| DnfPackageSet *pset = dnf_packageset_new (sack); | ||
| for (guint i = 0; i < pkglist->len; i++) | ||
| dnf_packageset_add (pset, pkglist->pdata[i]); | ||
| DnfPackageSet *pset = hy_query_run_set (query); |
There was a problem hiding this comment.
I have to claim a bit of ignorance on this one. It looks OK based on what I see here.
jlebon
force-pushed
the
pr/strict-lockfile-prep
branch
from
84c78f1 to
fe65986
Compare
|
OK, I think the behavior for the first commit makes sense for composes, but doesn't for the client side; We need to respect the default libdnf behavior there. That's why CI is failing. Basically only disable all repos if a |
jlebon
force-pushed
the
pr/strict-lockfile-prep
branch
from
fe65986 to
e86138e
Compare
Prep for future patch.
Otherwise, it muddles testing in `test-lockfile.sh` where we want to be in full control of all the lockfiles fed to `rpm-ostree compose tree`.
The garbage collection issue should be fixed now, and it's just nicer on developers' cache to stay on the same commit. And again, it's a nice sanity-check to know that we're always able to compose an older tree. That said, we probably should still bump this from time to time. While we're here, add some comments for making it easier to match `popd` calls with the original `pushd`.
Instead of manually recreating the packageset ourselves.
jlebon
force-pushed
the
pr/strict-lockfile-prep
branch
from
e86138e to
cc6a8a9
Compare
🎉 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
See individual commit messages