importer: Add some error prefixing#1889
Closed
cgwalters wants to merge 2 commits intocoreos:masterfrom
Closed
Conversation
Contributor
|
Minor: typo in commit message LGTM! |
cgwalters
force-pushed
the
importer-error-cleanup
branch
from
19c5e57 to
db9d984
Compare
Member
Author
|
Looks like containers/fuse-overlayfs#105 would fix this. |
Contributor
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 22, 2019
I was debugging a failure in cosa when running in unprivileged podman, with this patch the error is: `error: Importing package 'alternatives': Writing tmpfiles mtree: llistxattr: Is a directory` And that finally made it obvious to me that the problem is not using tmpfs for `/tmp` (well, this is a bug in fuse-overlayfs). Anyways, let's prefix errors some more on general principle. Closes: #1889 Approved by: rfairley
|
💔 Test failed - status-atomicjenkins |
Contributor
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 22, 2019
I was debugging a failure in cosa when running in unprivileged podman, with this patch the error is: `error: Importing package 'alternatives': Writing tmpfiles mtree: llistxattr: Is a directory` And that finally made it obvious to me that the problem is not using tmpfs for `/tmp` (well, this is a bug in fuse-overlayfs). Anyways, let's prefix errors some more on general principle. Closes: #1889 Approved by: rfairley
|
💔 Test failed - status-atomicjenkins |
I was debugging a failure in cosa when running in unprivileged podman, with this patch the error is: `error: Importing package 'alternatives': Writing tmpfiles mtree: llistxattr: Is a directory` And that finally made it obvious to me that the problem is not using tmpfs for `/tmp` (well, this is a bug in fuse-overlayfs). Anyways, let's prefix errors some more on general principle.
cgwalters
force-pushed
the
importer-error-cleanup
branch
from
db9d984 to
91f3fff
Compare
Member
Author
Should be fixed by 1027ade |
Contributor
|
👍 giving it another go! |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 22, 2019
I was debugging a failure in cosa when running in unprivileged podman, with this patch the error is: `error: Importing package 'alternatives': Writing tmpfiles mtree: llistxattr: Is a directory` And that finally made it obvious to me that the problem is not using tmpfs for `/tmp` (well, this is a bug in fuse-overlayfs). Anyways, let's prefix errors some more on general principle. Closes: #1889 Approved by: rfairley
cgwalters
force-pushed
the
importer-error-cleanup
branch
5 times, most recently
from
063aca9 to
f3c398b
Compare
Contributor
Hit this locally before but passed |
cgwalters
force-pushed
the
importer-error-cleanup
branch
from
f3c398b to
37bb6f4
Compare
Member
Author
|
Thanks for looking at that! I'm going to try what I think is a simpler solution than any of those on the wiki: |
Use --entrypoint and also rename it while we're here.
cgwalters
force-pushed
the
importer-error-cleanup
branch
from
37bb6f4 to
9ff6117
Compare
Member
Author
|
Woo, it works! That was only like 9 iterations of "I can just push this one more fix, don't need to test locally". Totally worked. @rh-atomic-bot r=rfairley 9ff6117 |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Aug 24, 2019
Use --entrypoint and also rename it while we're here. Closes: #1889 Approved by: rfairley
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging a failure in cosa when running in unprivleged podman,
with this patch the error is:
error: Importing package 'alternatives': Writing tmpfiles mtree: llistxattr: Is a directoryAnd that finally made it obvious to me that the problem is not using
tmpfs for
/tmp(well, this is a bug in fuse-overlayfs).Anyways, let's prefix errors some more on general principle.