COS-3639: manifest-c10s: switch to building via container tools#169
Conversation
This is part of https://issues.redhat.com/browse/COS-3639 and will switch the build of c10s over to the new way of building our base container images.
There was a problem hiding this comment.
Code Review
This pull request switches the build process for CentOS Stream CoreOS 10 to use container-based tools (buildah), aligning it with the build process already used for CentOS Stream CoreOS 9. This is achieved by setting build_with_buildah: true in manifest-c10s.yaml and removing configuration fields like metadata, variables, and versioning settings, which are presumably now handled by the new containerized build process. The changes are consistent with the stated goal and with other manifests in the repository that use the new build method. The changes look good.
|
The diff here between the non build-with-buildah path and the build-with-buildah path is very minimal. The largest difference at this point being:
(clean up handled in coreos/fedora-coreos-config#3997)
We don't need this file in CentOS Stream images anyway. There will also be missing labels on the image that we've typically done like: but we are meeting tomorrow to discuss the future of these labels and I'll add in code to add them back or add in the newly agreed upon labels once a decision is made about that. |
|
Just for reference - all the infrastructure changes for c10s is already done in the earlier c9s PR - #167 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaradhak, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dustymabe: This pull request references COS-3639 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is part of https://issues.redhat.com/browse/COS-3639 and will switch the build of c10s over to the new way of building our base container images.