Skip to content

COS-3639: manifest-c10s: switch to building via container tools#169

Merged
openshift-merge-bot[bot] merged 1 commit intocoreos:mainfrom
dustymabe:dusty-c10s-build-via-container-tools
Feb 3, 2026
Merged

COS-3639: manifest-c10s: switch to building via container tools#169
openshift-merge-bot[bot] merged 1 commit intocoreos:mainfrom
dustymabe:dusty-c10s-build-via-container-tools

Conversation

@dustymabe
Copy link
Copy Markdown
Member

This is part of https://issues.redhat.com/browse/COS-3639 and will switch the build of c10s over to the new way of building our base container images.

This is part of https://issues.redhat.com/browse/COS-3639 and
will switch the build of c10s over to the new way of building
our base container images.
@openshift-ci openshift-ci bot added the approved label Feb 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches the build process for CentOS Stream CoreOS 10 to use container-based tools (buildah), aligning it with the build process already used for CentOS Stream CoreOS 9. This is achieved by setting build_with_buildah: true in manifest-c10s.yaml and removing configuration fields like metadata, variables, and versioning settings, which are presumably now handled by the new containerized build process. The changes are consistent with the stated goal and with other manifests in the repository that use the new build method. The changes look good.

@dustymabe
Copy link
Copy Markdown
Member Author

The diff here between the non build-with-buildah path and the build-with-buildah path is very minimal. The largest difference at this point being:

  1. extra /etc/selinux/targeted/semanage.*.LOCK files

(clean up handled in coreos/fedora-coreos-config#3997)

  1. missing /usr/share/buildinfo/content_manifest.json

We don't need this file in CentOS Stream images anyway.

There will also be missing labels on the image that we've typically done like:

"io.openshift.build.versions": "machine-os=10.0.20260203-0",

but we are meeting tomorrow to discuss the future of these labels and I'll add in code to add them back or add in the newly agreed upon labels once a decision is made about that.

@aaradhak
Copy link
Copy Markdown
Member

aaradhak commented Feb 3, 2026

Just for reference - all the infrastructure changes for c10s is already done in the earlier c9s PR - #167

Copy link
Copy Markdown
Member

@aaradhak aaradhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe dustymabe changed the title manifest-c10s: switch to building via container tools COS-3639: manifest-c10s: switch to building via container tools Feb 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 3, 2026

@dustymabe: This pull request references COS-3639 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is part of https://issues.redhat.com/browse/COS-3639 and will switch the build of c10s over to the new way of building our base container images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dustymabe dustymabe added the lgtm label Feb 3, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 6991630 into coreos:main Feb 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants