NO-JIRA: tests: fix variable expansion in replace-rt-kernel

[dustymabe]

The code wasn't expanding the full array so we'd only get the first --install kernel-rt-core and not the full:

--install kernel-rt-core --install kernel-rt-modules \
--install kernel-rt-modules-extra --install kernel-rt-modules-core

[openshift-ci-robot]

@dustymabe: This pull request explicitly references no jira issue.

Details

In response to this:

The code wasn't expanding the full array so we'd only get the first --install kernel-rt-core and not the full:

--install kernel-rt-core --install kernel-rt-modules \ --install kernel-rt-modules-extra --install kernel-rt-modules-core

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the replace-rt-kernel test script where a bash array was not being fully expanded, resulting in an incomplete command. The change is correct and resolves the issue. I have added one suggestion to improve the code's robustness by quoting the array expansion, which is a shell scripting best practice.

[travier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dustymabe,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/scos-10-build-test-qemu	1771120	link	true	/test scos-10-build-test-qemu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dustymabe]

hmm. this seems to be a little more than just this problem.. this code does fix a bug but the test still fails.

I think the real problem is that rpm-ostree override reset -a seems to not be working:

[core@qemu0 ~]$ rpm -q rpm-ostree
rpm-ostree-2026.1-1.el10.x86_64
[core@qemu0 ~]$ sudo rpm-ostree override reset -a
[core@qemu0 ~]$

On CentOS 9 I see it doing more:

$ rpm -q rpm-ostree
rpm-ostree-2025.11-1.el9.x86_64
$ sudo rpm-ostree override reset -a
Staging deployment... done
Downgraded:
  kernel 5.14.0-665.el9 -> 5.14.0-664.el9
  kernel-core 5.14.0-665.el9 -> 5.14.0-664.el9
  kernel-modules 5.14.0-665.el9 -> 5.14.0-664.el9
  kernel-modules-core 5.14.0-665.el9 -> 5.14.0-664.el9
  kernel-modules-extra 5.14.0-665.el9 -> 5.14.0-664.el9
Run "systemctl reboot" to start a reboot

[jmarrero]

Likely the culprit is coreos/rpm-ostree#5510 I put a draft PR on coreos/rpm-ostree#5558 this might need more iterations just trying to see if Opus can one shot the fix.

[jmarrero]

You can safely just close this PR. The rpm-ostree PR: coreos/rpm-ostree#5558 resolves it without any test modification.

jmarrero@toolbx /v/h/j/d/c/rhcos> cosa kola run ext.config.rpm-ostree.replace-rt-kernel
kola -p qemu run ext.config.rpm-ostree.replace-rt-kernel --output-dir tmp/kola
...
=== RUN   ext.config.rpm-ostree.replace-rt-kernel
--- PASS: ext.config.rpm-ostree.replace-rt-kernel (242.59s)
PASS, output in tmp/kola
jmarrero@toolbx /v/h/j/d/c/rhcos> 

[dustymabe]

You can safely just close this PR.

Yes we can, but as written the code had a bug and this PR fixes it so I'm inclined to get it merged anyway.

[dustymabe]

I'll go ahead and merge this since it fixes a bug and once we get a new rpm-ostree it should unblock the kernel rt replace test too.