This repository was archived by the owner on May 7, 2021. It is now read-only.
*: add oscontainer pivot support #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Notably: both NFS related tests ( |
arithx
force-pushed
the
oscontainer_pivot
branch
from
9dd75b5 to
0860ebe
Compare
miabbott
reviewed
Mar 12, 2019
miabbott
reviewed
Mar 12, 2019
miabbott
reviewed
Mar 12, 2019
arithx
force-pushed
the
oscontainer_pivot
branch
2 times, most recently
from
26de310 to
971cec3
Compare
bgilbert
reviewed
Mar 13, 2019
arithx
force-pushed
the
oscontainer_pivot
branch
2 times, most recently
from
b3890c0 to
5dad743
Compare
Adds a new flag `--oscontainer` to `kola` which allows the specification of an oscontainer image pull spec when running against the `rhcos` distribution. When specified it will create the relevant files & the systemd units required to perform a `pivot` operation before `sshd` starts.
arithx
force-pushed
the
oscontainer_pivot
branch
from
5dad743 to
8ca2950
Compare
bgilbert
approved these changes
Mar 13, 2019
Also updates all tests using Ignition v1 to only run against the CL distribution. Neither FCOS nor RHCOS should ever expect to receive Ignition v1 configs.
arithx
force-pushed
the
oscontainer_pivot
branch
from
8ca2950 to
db4df2f
Compare
Contributor
Author
|
Pushed an update with a few more test disables. This one converts all Ignition v1 tests to be CL specific as neither RHCOS nor FCOS should ever be receiving these configs. |
bgilbert
approved these changes
Mar 13, 2019
miabbott
approved these changes
Mar 13, 2019
Member
miabbott
left a comment
miabbott
left a comment
There was a problem hiding this comment.
Thanks for improving the ostree/rpm-ostree tests!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag
--oscontainertokolawhich allows the specificationof an oscontainer image pull spec when running against the
rhcosdistribution. When specified it will create the relevant files & the
systemd units required to perform a
pivotoperation beforesshdstarts.
Closes #987