packet: Don't report umount stage status to Packet control plane #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't fail as a result of anything the user did, and ignition-dracut may have already torn down networking before umount runs.
Contributor
Author
|
After some further discussion, it appears that there's a consensus that we should keep networking available during the umount stage (coreos/ignition-dracut#163). Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreos/ignition-dracut#159 tears down initramfs networking before the
umountstage runs, causing Ignition to fail when reporting that stage's status to the Packet control plane. This can't be changed in ignition-dracut, sincecoreos-teardown-initramfs-network.shneeds filesystems to still be mounted so it can propagate the initramfs network config to the real root. However, nothing in the user's config is likely to causeumountto fail, so it's not as important to report that stage to the Packet console. Just skip reporting that stage.