Skip to content

Conversation

@laenion
Copy link
Contributor

@laenion laenion commented Aug 10, 2020

This pull request tries to fix two Makefile bugs of the install target:

  1. On 32 Bit x86 machines the ignition binaries were searched in the wrong directory due to a missing Go architectures <-> Linux hardware name; another mapping was introduced, handling various machine strings such as i486 or i686.
  2. Dracut and systemd are all installed with the default permissions of 755. Separate the files by extension and assign the matching permissions so the executable bit is only set for scripts. This will also avoid warning by systemd due to the incorrect permissions.

@jlebon
Copy link
Member

jlebon commented Aug 10, 2020

On 32 Bit x86 machines the ignition binaries were searched in the wrong directory due to a missing Go architectures <-> Linux hardware name; another mapping was introduced, handling various machine strings such as i486 or i686.

BTW, are you actually planning to use Ignition on 32-bit platforms? For FCOS/RHCOS at least, we don't currently support that and don't plan to. It's possible you'll hit other snags along the way.

@laenion
Copy link
Contributor Author

laenion commented Aug 12, 2020

BTW, are you actually planning to use Ignition on 32-bit platforms? For FCOS/RHCOS at least, we don't currently support that and don't plan to. It's possible you'll hit other snags along the way.

Not really, as we are not building MicroOS or Kubic for any 32 bit platform, either. However - as they are sharing their repository with Tumbleweed which supports i586 - I didn't see a reason to explicitly prevent it from building on x86. We don't have any automated tests of the x86 build, but Ignition seemed to be working fine so far, and I will see build failures (it's the second one, the first one was #944)...

@laenion
Copy link
Contributor Author

laenion commented Aug 19, 2020

We also got a community patch for 32 bit ARM machines. For our ARM images Ignition is currently the only way to configure the system, so we have active users for that architecture.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bgilbert bgilbert merged commit a7333e2 into coreos:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants