This repository was archived by the owner on Aug 25, 2021. It is now read-only.
dracut/30ignition: link to RHBZ in ignition-complete#74
Merged
jlebon merged 1 commit intocoreos:masterfrom Apr 5, 2019
Merged
Conversation
We shouldn't actually need to do `OnFailure=emergency.target` in `ignition-complete.service` here. Our unit is already a requirement of `initrd.target`, and so once we fail, `initrd.target` should fail, which in turn should trigger *its* `OnFailure=emergency.target`. However, this doesn't work in f29/el8: https://bugzilla.redhat.com/show_bug.cgi?id=1696796 Add a comment about that. See also: coreos#61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't actually need to do
OnFailure=emergency.targetinignition-complete.servicehere. Our unit is already a requirement ofinitrd.target, and so once we fail,initrd.targetshould fail, whichin turn should trigger its
OnFailure=emergency.target.However, this doesn't work in f29/el8:
https://bugzilla.redhat.com/show_bug.cgi?id=1696796
Add a comment about that.
See also: #61