Skip to content
This repository was archived by the owner on Aug 25, 2021. It is now read-only.

dracut/30ignition: link to RHBZ in ignition-complete#74

Merged
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/add-comment
Apr 5, 2019
Merged

dracut/30ignition: link to RHBZ in ignition-complete#74
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/add-comment

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Apr 5, 2019

We shouldn't actually need to do OnFailure=emergency.target in
ignition-complete.service here. Our unit is already a requirement of
initrd.target, and so once we fail, initrd.target should fail, which
in turn should trigger its OnFailure=emergency.target.

However, this doesn't work in f29/el8:
https://bugzilla.redhat.com/show_bug.cgi?id=1696796

Add a comment about that.

See also: #61

We shouldn't actually need to do `OnFailure=emergency.target` in
`ignition-complete.service` here. Our unit is already a requirement of
`initrd.target`, and so once we fail, `initrd.target` should fail, which
in turn should trigger *its* `OnFailure=emergency.target`.

However, this doesn't work in f29/el8:
https://bugzilla.redhat.com/show_bug.cgi?id=1696796

Add a comment about that.

See also: coreos#61
Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 85f2e65 into coreos:master Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants