This repository was archived by the owner on Aug 25, 2021. It is now read-only.
[spec2x] backport coreos-teardown-initramfs-network.service #175
+179
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of the merge commits f67d587 (coreos#159), and 390779d (coreos#174). The upstream commits persisted networking configuration and hostname as part of the teardown service so we also remove `persist-ifcfg.sh`.
dustymabe
changed the title
Member
Author
|
still doing some testing on this one.. |
Member
Author
|
Testing looks good in combination with |
jlebon
approved these changes
Apr 27, 2020
| EOF | ||
| fi | ||
|
|
||
| add_requires coreos-teardown-initramfs-network.service ignition-complete.target |
Member
There was a problem hiding this comment.
Hmm, I wonder if there was a reason we enabled it via the generator before vs statically. Ahhh, probably because it predates the backporting of ignition-complete.target.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the merge commits f67d587 (#159), and
390779d (#174). The upstream commits persisted networking
configuration and hostname as part of the teardown service so we
also remove
persist-ifcfg.sh.