This repository was archived by the owner on Aug 25, 2021. It is now read-only.
Add Journald 'forward to kernel log buffer' option#13
Merged
dustymabe merged 1 commit intocoreos:masterfrom Jul 21, 2018
Merged
Add Journald 'forward to kernel log buffer' option#13dustymabe merged 1 commit intocoreos:masterfrom
dustymabe merged 1 commit intocoreos:masterfrom
Conversation
Member
|
Looks reasonable to me. @dustymabe ⬆️ |
Member
|
anyone have an opinion on if we should just put this new option in the other file or not (and rename the other file to something like |
Member
|
I'm fine either way. |
Contributor
Author
|
I would prefer one file |
This makes ignition logs show up on ttyS0. Without this option, ignition logs only shows up on tty0.
Contributor
Author
|
I moved everything to one file. |
Member
|
LGTM |
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ignition logs show up on ttyS0. Without this option, ignition logs only shows up on tty0.
Related to openshift/os#158