This repository was archived by the owner on Aug 25, 2021. It is now read-only.
ignition-firstboot-complete.service: Run as part of basic.target#124
Merged
miabbott merged 1 commit intocoreos:masterfrom Oct 23, 2019
Merged
ignition-firstboot-complete.service: Run as part of basic.target#124miabbott merged 1 commit intocoreos:masterfrom
miabbott merged 1 commit intocoreos:masterfrom
Conversation
See: openshift/installer#2554 Basically the OpenShift installer on vSphere injects a service which reboots the first time, but I believe this could easily race with `ignition-firstboot-complete`. Let's mark the boot complete much earlier.
Contributor
|
We've talked in the past about moving this into the initramfs like it is on CL. Any reason not to move it there? |
Member
Author
|
I can't think of a reason not to do that. Though it'd break #117 (since zipl isn't in the initramfs) but we could probably address that by just adding it. |
Member
Author
|
So...let's get this easy fix in first though? |
miabbott
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: openshift/installer#2554
Basically the OpenShift installer on vSphere injects a service which reboots
the first time, but I believe this could easily race with
ignition-firstboot-complete.Let's mark the boot complete much earlier.