Skip to content
This repository was archived by the owner on Aug 25, 2021. It is now read-only.

dracut: add some bins for s390x zVM instalation #118

Merged
jlebon merged 1 commit into from
Dec 11, 2019
Merged

dracut: add some bins for s390x zVM instalation #118

jlebon merged 1 commit into from
Dec 11, 2019

Conversation

@tuan-hoang1
Copy link
Contributor

@tuan-hoang1 tuan-hoang1 commented Oct 11, 2019

To support coreos/ignition#865

Reported-by: XiaoMeiZheng xmzheng@cn.ibm.com

@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Oct 11, 2019

cc @zhengxiaomei123

lucab
lucab reviewed Oct 11, 2019
View reviewed changes
@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Oct 14, 2019

cc @barthy1

@tuan-hoang1
dracut: add some bins for s390x zVM instalation
7cf7bbe 
To support coreos/ignition#865

Reported-by: XiaoMeiZheng <xmzheng@cn.ibm.com>
@tuan-hoang1 tuan-hoang1 mentioned this pull request Oct 18, 2019
Closed
33 tasks
@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Nov 29, 2019

@zhengxiaomei123 @jichenjc: do we need this for 4.2 ?

@zhengxiaomei123
Copy link

zhengxiaomei123 commented Dec 2, 2019

@zhengxiaomei123 @jichenjc: do we need this for 4.2 ?

Yes. If possible, please make it work for 4.2.

@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Dec 4, 2019

@zhengxiaomei123: f yes then we probably need to backport coreos/ignition#865 to Ignition's spec2x branch.

@zhengxiaomei123
Copy link

zhengxiaomei123 commented Dec 4, 2019 •
edited
Loading

@zhengxiaomei123: f yes then we probably need to backport coreos/ignition#865 to Ignition's spec2x branch.

Because [coreos/ignition#865] is merged to master branch and it is not used for z/VM UPI case till now, I think let's wait for this patch to be merged into master branch not sepc2x along with [coreos/ignition#865] .

@tuan-hoang1
Copy link
Contributor Author

tuan-hoang1 commented Dec 4, 2019

@zhengxiaomei123 : ok so if/when you backport coreos/ignition#865 to spec2x (for 4.3, etc.) please let me know.
@lucab : Hi Luca, could we go head with this PR ?

jlebon
jlebon approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is still required, right? LGTM.

@zhengxiaomei123
Copy link

zhengxiaomei123 commented Dec 11, 2019 •
edited
Loading

I assume this is still required, right? LGTM.

Yes, It is necessary for coreos/ignition#865.

@jlebon jlebon merged commit c4790bc into coreos:master Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@lucab lucab lucab left review comments

@zhengxiaomei123 zhengxiaomei123 zhengxiaomei123 left review comments

@jlebon jlebon jlebon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tuan-hoang1 @zhengxiaomei123 @lucab @jlebon