Add gatewayd journal client #86
Conversation
|
lgtm, could you add a MAINTAINERS file in this directory with your name? |
|
Copyright header please. |
gatewayd/journal_test.go
Outdated
There was a problem hiding this comment.
These don't match to the actual names
There was a problem hiding this comment.
That's weird..I must have accidentally broken the tests in a rebase before I submitted the PR. Should be fixed. I also found a bug with something else, noted in a comment to this PR.
|
I found a small bug in my implementation with the Message field. Things were not marshalling correctly into it. I found a slightly better alternative to a getter method as well. I basically implement a custom Unmarshal function that handles the varying types of data from the journald |
chancez
force-pushed
the
gatewayd
branch
2 times, most recently
from
b6fb0ff to
5219297
Compare
There was a problem hiding this comment.
I adapted this from somewhere else to handle storing a string representation on the Entry struct.
http://www.freedesktop.org/wiki/Software/systemd/json/ has details about it. The []interface{} case should deal with non-printable non-utf8 characters. But I'm not 100% sure that's correct
|
@chancez I randomly stepped on this PR today. Do we still want to drive this toward master or should I just close this PR? |
|
Can one of the admins verify this patch? |
|
@lucab It can be closed, but I also see no reason it couldn't be merged. |
|
@chancez I seem to understand the original usecase is not anymore pressing. While I don't have any particular issue with this PR, I see this is mostly just an HTTP API client not strictly related to libsystemd. I'm closing this for now, but I think it can be easily resurrected or split in its own projects if there is any need for this. |
4 participants
No description provided.