Skip to content

*: add sanity check to avoid JWT over-allocation #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericchiang merged 1 commit into from
Jan 13, 2026
+9 −0
Merged

*: add sanity check to avoid JWT over-allocation #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,15 @@ func parseClaim(raw []byte, name string, v interface{}) error {
//
// token, err := verifier.Verify(ctx, rawIDToken)
func (v *IDTokenVerifier) Verify(ctx context.Context, rawIDToken string) (*IDToken, error) {
if strings.Count(rawIDToken, ".") > 2 {
// Older versions of go-jose are vulnerable to a scenario where
// strings.Cut(token, ".") can lead to excessive allocations. Since the
// "v2" branch of this repo explicitly doesn't update its dependencies
// at the request of Kubernetes, add a check here first.
//
// https://github.com/go-jose/go-jose/security/advisories/GHSA-c6gw-w398-hv78
return nil, fmt.Errorf("oidc: malformed jwt")
}
jws, err := jose.ParseSigned(rawIDToken)
if err != nil {
return nil, fmt.Errorf("oidc: malformed jwt: %v", err)
Expand Down
Loading