Fix issuer validation error message order#468
Closed
Conversation
Author
ericchiang
added a commit
to ericchiang/go-oidc
that referenced
this pull request
Nov 21, 2025
ericchiang
added a commit
that referenced
this pull request
Nov 21, 2025
Collaborator
|
Thanks! I went ahead and sent #469 to get ride of the "want" and "got" language |
yusing
pushed a commit
to godoxy-app/go-oidc
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small correction to an error message in the
NewProviderfunction inoidc/oidc.go. The order of the "expected" and "got" values in the error message was swapped to accurately reflect the actual and expected issuer values.