Skip to content

pipeline: switch default branch to testing-devel#74

Merged
jlebon merged 2 commits intocoreos:masterfrom
jlebon:pr/default-branch
Jun 13, 2019
Merged

pipeline: switch default branch to testing-devel#74
jlebon merged 2 commits intocoreos:masterfrom
jlebon:pr/default-branch

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Jun 13, 2019

This will shortly be the default branch in the repo.

jlebon added 2 commits June 13, 2019 15:16
@jlebon
pipeline: switch default branch to testing-devel
1a06900 
This will shortly be the default branch in the repo.
@jlebon
devel-up: query for default branch when resolving refspecs
6ecc320 
Instead of hardcoding `master`, just use `git ls-remote` to figure out
the default branch. E.g. once we switch to `testing-devel` as the
default branch in `fedora-coreos-config`, this will transparently keep
working.
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 13, 2019

Hmm actually, maybe it's cleaner to just make it blank, and handle that in the Groovy code so git clone does the right thing.

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 13, 2019

LGTM

Maybe we should leave a master branch with a single file README.md that explains the setup of the repo.

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 13, 2019

Maybe we should leave a master branch with a single file README.md that explains the setup of the repo.

that is for the fedora-coreos-config repo

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 13, 2019

Hmm actually, maybe it's cleaner to just make it blank, and handle that in the Groovy code so git clone does the right thing.

Hmm nevermind, seems like BuildConfigs default to master rather the real default branch. So let's roll with what we have here!

Maybe we should leave a master branch with a single file README.md that explains the setup of the repo.

Hmm, kinda like in the RHEL dist-git? Wouldn't having a master branch at all send mixed signals though? Seems clearer to just not have it at all so anything trying to clone/checkout master just fails. But yeah, definitely we should explain the setup in the README.md on the default branch.

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 13, 2019

Hmm, kinda like in the RHEL dist-git? Wouldn't having a master branch at all send mixed signals though? Seems clearer to just not have it at all so anything trying to clone/checkout master just fails. But yeah, definitely we should explain the setup in the README.md on the default branch.

ok - i'm cool either way

@jlebon jlebon merged commit a0a03e0 into coreos:master Jun 13, 2019
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 13, 2019

But yeah, definitely we should explain the setup in the README.md on the default branch.

coreos/fedora-coreos-config#102

@jlebon jlebon deleted the pr/default-branch branch April 24, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlebon @dustymabe