Skip to content

Jenkinsfile.*: do cosa init before buildprep#150

Merged
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/init-before-buildprep
Oct 15, 2019
Merged

Jenkinsfile.*: do cosa init before buildprep#150
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/init-before-buildprep

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Oct 15, 2019

After [1], buildprep wants to write to tmp/ but that directory
doesn't exist yet. Really, we should be nice to cosa and init the
workdir first so it doesn't get confused.

[1] coreos/coreos-assembler#823

After [1], `buildprep` wants to write to `tmp/` but that directory
doesn't exist yet. Really, we should be nice to cosa and `init` the
workdir first so it doesn't get confused.

[1] coreos/coreos-assembler#823
Copy link
Copy Markdown
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit ef6c053 into coreos:master Oct 15, 2019
@jlebon jlebon deleted the pr/init-before-buildprep branch October 15, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants