tests: misc-ro: make systemd-resolved service check conditional#646
Merged
dustymabe merged 2 commits intocoreos:testing-develfrom Sep 30, 2020
Merged
tests: misc-ro: make systemd-resolved service check conditional#646dustymabe merged 2 commits intocoreos:testing-develfrom
dustymabe merged 2 commits intocoreos:testing-develfrom
Conversation
Member
Author
|
will merge after #575 |
This PR adds the systemd-resolved packages into FCOS. It is going to be used by default in Fedora 33 per this change request: https://fedoraproject.org/wiki/Changes/systemd-resolved Adding the systemd-resolved packages back in gets us ready for this change. It won't impact how DNS is configured or used and it lets users get ready for the change in Fedora 33.
dustymabe
changed the title
Make the systemd-resolved service check conditional on Fedora major version. In Fedora 32 it should be disabled. In Fedora 33+ it should be enabled by default.
dustymabe
force-pushed
the
dusty-systemd-resolved
branch
from
369c4bd to
afa1c9e
Compare
jlebon
approved these changes
Sep 30, 2020
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
LGTM! I think we can just merge this one and close the other one included here? That avoids sending out a webhook event for a build state which is gonna fail tests anyway.
| done | ||
| # systemd-resolved should be disabled on f32 but | ||
| # enabled on f33+. | ||
| source /etc/os-release |
Member
There was a problem hiding this comment.
I usually prefer to source this in a subshell to avoid polluting the env, but this is OK too.
Member
Author
OK. Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the systemd-resolved service check conditional on Fedora major
version. In Fedora 32 it should be disabled. In Fedora 33+ it should
be enabled by default.