live-generator: A few systemd ordering tweaks#506
Merged
jlebon merged 1 commit intocoreos:testing-develfrom Sep 23, 2020
Merged
live-generator: A few systemd ordering tweaks#506jlebon merged 1 commit intocoreos:testing-develfrom
jlebon merged 1 commit intocoreos:testing-develfrom
Conversation
Member
Author
|
This pulls in some review feedback from #499 |
jlebon
approved these changes
Jul 3, 2020
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Makes sense to me!
I think before we merge this, we should add some basic testiso tests to CI here. Except CI is broken right now. :|
No actual functional changes I believe. The main thing here is explicitly doing the `Wants=systemd-udev-settle.service` to pull it in (even though it already is from `multipathd.service`, that might change).
cgwalters
force-pushed
the
more-iso-cleanups
branch
from
50e32ff to
805a4fe
Compare
Member
Author
|
Rebased 🏄 and we have testiso running here now.. |
jlebon
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No actual functional changes I believe. The main thing
here is explicitly doing the
Wants=systemd-udev-settle.serviceto pull it in (even though it already is from
multipathd.service,that might change).