Drop multipath-generator#433
Merged
darkmuggle merged 1 commit intocoreos:testing-develfrom May 28, 2020
darkmuggle:pr/mpath-gen
Merged
Drop multipath-generator#433darkmuggle merged 1 commit intocoreos:testing-develfrom darkmuggle:pr/mpath-gen
darkmuggle merged 1 commit intocoreos:testing-develfrom
darkmuggle:pr/mpath-gen
Conversation
The multipath generator was a nice idea to help make things automatic based on `rd.multipath=default`. However, changes in Ignition Dracut and the direction of using explict kargs makes this well-intentioned module cruft. See: coreos/fedora-coreos-tracker#465
Contributor
Author
|
Users wishing to use multipath will need to do |
Member
|
I'm always in favor of less shell script run as root! Having things be more explicit makes sense to me. I am wondering though how mpath will interact with rootfs reprovisioning, but perhaps that code can do "use current root= arg if present, otherwise just /dev/disk/by-label/root". |
Contributor
Author
For root reprovisioning, then would have to use |
Member
|
A bit late, but LGTM! |
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
Bump fedora-coreos-config to get ordering cycle fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multipath generator was a nice idea to help make things automatic
based on
rd.multipath=default. However, changes in Ignition Dracut andthe direction of using explict kargs makes this well-intentioned module
cruft.
See: coreos/fedora-coreos-tracker#465