Skip to content

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Mar 26, 2020

We need to make sure that the osmet files in the initrd are kept
somewhere accessible in the real root where coreos-installer will find
them. Have a simple unit which copies them over to the right spot.

@jlebon
Copy link
Member Author

jlebon commented Mar 26, 2020

Requires: coreos/coreos-assembler#1244
Requires: coreos/coreos-installer#187

@cgwalters
Copy link
Member

This will persistently take up RAM even if the user isn't going to do an install, right?

We could fix that by doing e.g. lsinitrd --unpack or something to get it instead.

@jlebon
Copy link
Member Author

jlebon commented Mar 26, 2020

We don't have access to the initrd in a live scenario though, right? (I mean, other than it already being loaded in RAM in the first place). I guess in the live ISO case where the media isn't removed yet, you could use that, though for 5M seems cleaner to just have it work the same across all live scenarios.

@jlebon
Copy link
Member Author

jlebon commented Mar 26, 2020

One related thing is /run/initramfs, which systemd can use to go back to the initrd on shutdown. I don't think we make use of that in Fedora at least though, since the whole initrd filesystem is nuked on pivot: https://github.com/systemd/systemd/blob/6281c6e56c51f45edbf41a83fd13c9d290f6a691/src/shared/switch-root.c#L123.

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK yeah, not worth worrying about a few MB right now.

We need to make sure that the osmet files in the initrd are kept
somewhere accessible in the real root where coreos-installer will find
them. Have a simple unit which copies them over to the right spot.
@jlebon
Copy link
Member Author

jlebon commented Apr 29, 2020

I just tweaked this slightly so that it doesn't error out if no osmet files are present. That way it's safe to merge this right now so that we can use it in the CI for coreos/coreos-installer#187.

Feel free to do another review. Otherwise will merge on green!

@jlebon jlebon merged commit 8331d73 into coreos:testing-devel Apr 29, 2020
@jlebon jlebon deleted the pr/osmet branch April 29, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants