tests: add a test that can be run manually for net testing#316
Merged
cgwalters merged 1 commit intocoreos:testing-develfrom Mar 30, 2020
Merged
tests: add a test that can be run manually for net testing#316cgwalters merged 1 commit intocoreos:testing-develfrom
cgwalters merged 1 commit intocoreos:testing-develfrom
Conversation
This was referenced Mar 24, 2020
Member
Author
|
I went though and talked to @jlebon about where would be the best place to put something like this. We came up with |
8423768 to
3cdfc62
Compare
This is how I've been doing network testing for the NM in the initrd PR (coreos#310). One day I'd like to convert this into some more sophisticated test that can be run in our CI but AFAIU right now that's not possibly because our CI is limited to qemu unprivileged networking. For now let's put this $somewhere so that we can pull it out at least when we suspect problems.
3cdfc62 to
399d58c
Compare
Member
|
OK yeah, this looks like a net win. See some discussions in coreos/fedora-coreos-tracker#340 for libvirt. |
Contributor
|
Isn't this something that belongs to coreos-assembler / mantle? Even if not part of automated CI, it would helpful not to start sprawling scripts around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how I've been doing network testing for the NM in
the initrd PR (#310).
One day I'd like to convert this into some more sophisticated
test that can be run in our CI but AFAIU right now that's not
possibly because our CI is limited to qemu unprivileged networking.
For now let's put this $somewhere so that we can pull it out
at least when we suspect problems.