manifest: Add excludes for python,perl,nodejs,dnf,grubby#280
Merged
jlebon merged 1 commit intocoreos:testing-develfrom Feb 10, 2020
Merged
manifest: Add excludes for python,perl,nodejs,dnf,grubby#280jlebon merged 1 commit intocoreos:testing-develfrom
jlebon merged 1 commit intocoreos:testing-develfrom
Conversation
This makes use of the new coreos/rpm-ostree#1980 And we can then drop the test in kola that boots a whole VM for this.
Member
|
/approve |
cgwalters
added a commit
to cgwalters/mantle
that referenced
this pull request
Feb 11, 2020
Let's rely on coreos/fedora-coreos-config#280 - starting a whole VM for this is a bit silly. And in the future if we do add more tests like this I think we should do it via tests that run the OS as a container, or are part of a set of explicitly "nondestructive" tests that we can run multiple in a single VM with less overhead etc.
zonggen
pushed a commit
to zonggen/mantle
that referenced
this pull request
Feb 13, 2020
Let's rely on coreos/fedora-coreos-config#280 - starting a whole VM for this is a bit silly. And in the future if we do add more tests like this I think we should do it via tests that run the OS as a container, or are part of a set of explicitly "nondestructive" tests that we can run multiple in a single VM with less overhead etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of the new
coreos/rpm-ostree#1980
And we can then drop the test in kola that boots a whole VM
for this.