F38 Change: Kola test for Shorter shutdown timer #2244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travier
reviewed
Feb 17, 2023
| ## exclusive: false | ||
| ## | ||
| ## Checks if default shutdown time is 2 mins an 45 seconds | ||
| ## |
travier
requested changes
Feb 17, 2023
| ## kola: | ||
| ## exclusive: false | ||
| ## | ||
| ## Checks if default shutdown time is 2 mins an 45 seconds |
Member
There was a problem hiding this comment.
Suggested change
| ## Checks if default shutdown time is 2 mins an 45 seconds | |
| # Checks if default shutdown time is 2 mins an 45 seconds |
This needs to be a single #. We use double # for special kola comments, and single # for normal comments.
Member
There was a problem hiding this comment.
|
|
||
| # set -xeuo pipefail | ||
|
|
||
| # . $KOLA_EXT_DATA/commonlib.sh |
Member
There was a problem hiding this comment.
You need to create a folder and a symbolic link for this to work like all other tests. Look for them in other tests folders.
| ## Checks if default shutdown time is 2 mins an 45 seconds | ||
| ## | ||
|
|
||
| # set -xeuo pipefail |
Member
There was a problem hiding this comment.
We need this one. Your test should pass with this set.
Member
|
Moved to #2247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests if a systems shutdown timer is 2 mins and 45 seconds