Skip to content

manifest: add libvarlink-util#154

Merged
dustymabe merged 1 commit intocoreos:testing-develfrom
dustymabe:dusty
Aug 22, 2019
Merged

manifest: add libvarlink-util#154
dustymabe merged 1 commit intocoreos:testing-develfrom
dustymabe:dusty

Conversation

@dustymabe
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 850322a into coreos:testing-devel Aug 22, 2019
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Sep 5, 2019

FWIW, this should've included a corresponding lockfile 🔒 entry as described in https://github.com/coreos/fedora-coreos-config#adding-packages-to-the-os.

This will also be a hard requirement if we want to switch to strict lockfile mode (coreos/rpm-ostree#1858).

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Sep 5, 2019

(To be clear, this still worked fine by virtue of the manifest being propagated to bodhi-updates, then an updated lockfile being promoted back down. The issue is that before that happens, testing-devel isn't completely defined, and so we can't promote it to testing. testing only uses coreos-pool now, which won't have the package until coreos-koji-tagger picks it up from the lockfile).

dustymabe pushed a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship libvarlink-utils

3 participants