overlay.d/05core: Fix boot-efi.mount unit dependency#141
Closed
jcajka wants to merge 1 commit intocoreos:testing-develfrom
Closed
overlay.d/05core: Fix boot-efi.mount unit dependency#141jcajka wants to merge 1 commit intocoreos:testing-develfrom
jcajka wants to merge 1 commit intocoreos:testing-develfrom
Conversation
Contributor
Author
|
For the record tested only on ppc64le, working on other arches atm. |
Member
|
@jcajka - can you report back once you've tested on other arches? |
Contributor
Author
Sure. |
Member
Contributor
|
Won't this still try to pull in the device node, but just make the failure non-fatal? Conditionalized units still pull in their dependencies even if the condition fails. Avoiding that generally requires a systemd generator. #155 moves |
Member
|
Yeah, this will be obsoleted by #155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #115