Skip to content

manifests: move fedora-coreos-pool to fedora-coreos.yaml#1108

Merged
jlebon merged 1 commit intocoreos:testing-develfrom
jlebon:pr/share-pool
Jul 14, 2021
Merged

manifests: move fedora-coreos-pool to fedora-coreos.yaml#1108
jlebon merged 1 commit intocoreos:testing-develfrom
jlebon:pr/share-pool

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Jul 14, 2021

This is common to all streams, so we can move it here. I had initially
kept it in manifest.yaml because of:

#355 (comment)

This is common to all streams, so we can move it here. I had initially
kept it in `manifest.yaml` because of:

coreos#355 (comment)
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jul 14, 2021

So after this, we should be able to drop repos from all the manifests for production streams.

@dustymabe
Copy link
Copy Markdown
Member

So after this, we should be able to drop repos from all the manifests for production streams.

Is there a reason the production streams have repos in there now and not lockfile-repos:?

Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon enabled auto-merge (rebase) July 14, 2021 14:29
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jul 14, 2021

So after this, we should be able to drop repos from all the manifests for production streams.

Is there a reason the production streams have repos in there now and not lockfile-repos:?

They just haven't been updated at all since adding support for lockfile-repos in rpm-ostree because it initially broke if only lockfile-repos was defined, and no repos.

@jlebon jlebon merged commit a8ec676 into coreos:testing-devel Jul 14, 2021
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jul 14, 2021

Let's update the production branches after the current releases are clear.

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jul 19, 2021

Let's update the production branches after the current releases are clear.

OK right, let's do this at promotion time instead so we don't update non-manifest.yaml files out of cycle. Added a note in coreos/fedora-coreos-streams#339 and coreos/fedora-coreos-streams#338.

travier added a commit to coreosbot-releng/fedora-coreos-config that referenced this pull request Jul 27, 2021
travier added a commit to coreosbot-releng/fedora-coreos-config that referenced this pull request Jul 27, 2021
cverna added a commit to coreosbot-releng/fedora-coreos-config that referenced this pull request Aug 9, 2021
cverna added a commit to coreosbot-releng/fedora-coreos-config that referenced this pull request Aug 9, 2021
cverna added a commit that referenced this pull request Aug 9, 2021
@jlebon jlebon deleted the pr/share-pool branch April 23, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants