Skip to content

manifest: set ref to bodhi-updates#104

Merged
jlebon merged 2 commits intocoreos:bodhi-updatesfrom
jlebon:pr/bodhi-updates
Jun 14, 2019
Merged

manifest: set ref to bodhi-updates#104
jlebon merged 2 commits intocoreos:bodhi-updatesfrom
jlebon:pr/bodhi-updates

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Jun 13, 2019

This is the bodhi-updates stream. Right now, this is identical
otherwise to testing-devel, though in the future, the latter should
only be sourcing from coreos-pool, as opposed to the stable repos as
well.

@jlebon jlebon mentioned this pull request Jun 13, 2019
8 tasks
@dustymabe
Copy link
Copy Markdown
Member

LGTM - should we wait for the #102 to merge first and rebase?

@sinnykumari
Copy link
Copy Markdown
Contributor

unless we are relying something from coreos-pool, should we remove fedora-coreos-pool repo from manifest.yaml? That way repos list will be equivalent to what should be for bodhi-updates.

@dustymabe
Copy link
Copy Markdown
Member

unless we are relying something from coreos-pool, should we remove fedora-coreos-pool repo from manifest.yaml? That way repos list will be equivalent to what should be for bodhi-updates.

+1 - good catch sinny. This is one of our mechanical refs so it should just be pulling from fedora release and bodhi-updates repo.

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 14, 2019

Yeah, I left it in there (and thought I had mentioned it in the commit message, but only did for the opposite case of testing-devel and Bodhi repos), but basically: right now we're abusing the coreos-pool tag a bit by manually tagging things in to short-circuit Bodhi. I agree long-term this is what we want, but until then, we don't want to be in a situation where bodhi-updates pulls in older packages than testing-devel.

@dustymabe
Copy link
Copy Markdown
Member

we don't want to be in a situation where bodhi-updates pulls in older packages than testing-devel.

i think that's going to be a reality for us for a while for a subset of packages (at least until we can automate some interactions and gating in bodhi a bit). My thoughts here are that we'd take the lockfile from the passive stream (bodhi-updates) and we have an overrides file in testing-devel where we add in our rpms that override those from the passive stream. These overrides rpms would be ones that we wanted to fast track (new features or backported fixes in rpms that were never going to bodhi).

jlebon added 2 commits June 14, 2019 12:11
E.g. for afterburn.
This is the `bodhi-updates` stream. Drop `fedora-coreos-pool`, enable
the modular repos, and most importantly, rename the ref accordingly.
@jlebon jlebon force-pushed the pr/bodhi-updates branch from 9d5e7d9 to 92b58b4 Compare June 14, 2019 16:21
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Jun 14, 2019

Had a chat with @dustymabe, @sinnykumari, and @bgilbert about this. To summarize: we're keeping bodhi-updates away from coreos-pool so that the overrides in testing-devel truly represents the "diff" from Fedora stable. The downside (upside?) is that we need to keep a closer eye tracking our overrides, but we don't expect that many so it shouldn't be too much maintenance.

I've updated the PR to drop coreos-pool and add the modular repos! ⬆️

@dustymabe
Copy link
Copy Markdown
Member

LGTM

@jlebon jlebon merged commit ebb8597 into coreos:bodhi-updates Jun 14, 2019
@jlebon jlebon deleted the pr/bodhi-updates branch July 4, 2019 21:55
jlebon added a commit to jlebon/fedora-coreos-config that referenced this pull request Nov 8, 2019
As discussed in coreos#104,
we don't actually want the bodhi-updates stream to pull in newer
packages from the pool.

That said, bodhi-updates also current acts as our lockfile updater in
testing-devel, so it's crucial that it keeps working. We're working to
decouple that, see:

coreos/fedora-coreos-tracker#293
coreos/fedora-coreos-releng-automation#48

But for now, the updates must flow...
jlebon added a commit that referenced this pull request Nov 8, 2019
As discussed in #104,
we don't actually want the bodhi-updates stream to pull in newer
packages from the pool.

That said, bodhi-updates also current acts as our lockfile updater in
testing-devel, so it's crucial that it keeps working. We're working to
decouple that, see:

coreos/fedora-coreos-tracker#293
coreos/fedora-coreos-releng-automation#48

But for now, the updates must flow...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants