Skip to content

install: use 4k image when when targeting 4k drives #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jlebon merged 3 commits into from
Apr 3, 2020
Merged

install: use 4k image when when targeting 4k drives #203

jlebon merged 3 commits into from
Apr 3, 2020

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Mar 31, 2020

Detect the sector size of the target device, then select the right
format from the stream metadata based on that.

Closes: #201

@jlebon jlebon mentioned this pull request Mar 31, 2020
Closed
@jlebon
Copy link
Member Author

jlebon commented Mar 31, 2020

(Working on enhancing kola testiso to also test 4k installs.)

cgwalters
cgwalters reviewed Mar 31, 2020
View reviewed changes
bgilbert
bgilbert reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jlebon
Copy link
Member Author

jlebon commented Apr 1, 2020

OK so coreos/coreos-assembler#1312 enhances kola testiso for testing metal4k image installs. Will hook it up here and in the pipeline too afterwards, though it doesn't actually test the new codepath here since we're not doing a stream install. We could work on mocking that though... not sure if we should block on this. I did test this code on the current stable stream metadata though and it did the right thing. :)

Will address review comments tomorrow!

jlebon added 2 commits April 2, 2020 10:07
@jlebon
install: use 4k image when when targeting 4k drives
e9f7673 
Detect the sector size of the target device, then select the right
format from the stream metadata based on that.

Closes: #201
@jlebon
source: display image format from stream
85961d8 
This makes it easier for the user to tell that the right image is being
downloaded for the target device.
@jlebon
Copy link
Member Author

jlebon commented Apr 2, 2020

I added another commit here which adds metal4k testing in CI!

@jlebon jlebon mentioned this pull request Apr 2, 2020
Merged
@jlebon
ci: hook up metal4k installer tests
0905dd2 
`kola testiso` knows how to do this now!
@jlebon jlebon merged commit 893f878 into coreos:master Apr 3, 2020
@jlebon jlebon deleted the pr/4k-stream branch April 3, 2020 13:50
@jlebon jlebon mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters left review comments

+1 more reviewer

@bgilbert bgilbert bgilbert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically select 4k metal image when needed

3 participants

@jlebon @cgwalters @bgilbert