Change default cosa --strict parameter#58
Conversation
ravanelli
requested review from
bh7cw,
darkmuggle,
jlebon and
mike-nguyen
as code owners
vars/fcosBuild.groovy
Outdated
|
|
||
| def extraFetchArgs = params.get('extraFetchArgs', ""); | ||
| shwrap("cd ${cosaDir} && cosa fetch --strict ${extraFetchArgs}") | ||
| def extraFetchArgs = params.get('extraFetchArgs', "--strict"); |
There was a problem hiding this comment.
I think normally you do always want strict mode turned on in CI because it ensures that the lockfiles are the complete sources of truth (see coreos/rpm-ostree#1858 and coreos/fedora-coreos-tracker#454). Essentially, non-strict mode is useful mostly for the developer case.
In the case of RHCOS, which doesn't use lockfiles yet, using cosa {fetch,build} --strict should have no effect.
That said, it does make sense to make this configurable to be flexible (and e.g. allow developers to hack up the manifest quickly and fire up a Jenkins job for it).
Instead of putting this in extraFetchArgs and extraArgs, and potentially having callers which already use these lose the --strict arg, WDYT about adding a new strict bool instead which defaults to true?
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Minor bikeshed, otherwise LGTM! :)
vars/fcosBuild.groovy
Outdated
| // Available parameters: | ||
| // make: boolean -- run `make && make install DESTDIR=...` | ||
| // skipInit: boolean -- assume `cosa init` has already been run | ||
| // skipStrict boolean -- do not run cosa using `--strict' option |
There was a problem hiding this comment.
Hmm, skip... so far has been about skipping executing some steps. If you prefer the "default to false" semantics, I think this is closer to noForce -- how about calling this noStrict to match it?
In order to be more flexible across the CIs remove the `--strict` default option. And let who is calling it define the parameters. We have cases where we don't want to use `--strict`. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
2 participants
In order to be more flexible across the CIs
remove the
--strictdefault option. And letwho is calling it define the parameters.
We have cases where we don't want to use
--strict.Signed-off-by: Renata Ravanelli rravanel@redhat.com