Merged
Conversation
Member
Author
|
(Not tested) |
I think this is better than calling it `privileged` as that has a specific meaning in Docker/Kubernetes. See my argument at https://lwn.net/Articles/796885/
jlebon
approved these changes
Sep 13, 2019
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
LGTM! Just updated the docstring.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Oct 31, 2019
It's the same thing for now for backwards compatibility, but privileged has a different connotation from "running as uid 0". See for details: coreos/coreos-ci-lib#3
cgwalters
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Oct 31, 2019
It's the same thing for now for backwards compatibility, but privileged has a different connotation from "running as uid 0". See for details: coreos/coreos-ci-lib#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is better than calling it
privilegedas thathas a specific meaning in Docker/Kubernetes.
See my argument at https://lwn.net/Articles/796885/