fcosKola: Automatically pick up tests/kola

[cgwalters]

So we can use -E in CI, see
coreos/coreos-assembler#1252

[cgwalters]

(Totally didn't test this)

[jlebon]

Ahh yup, you're right we need to enhance this step here for coreos/fedora-coreos-config#305.

Hmm, how about instead of this, we automatically pass --exttest src/config/tests/kola if we find that the directory exists? In general, I want to establish conventions to make it dead easy to do the right thing.

[jlebon]

I can pick this up if you'd like!

[cgwalters]

we automatically pass --exttest src/config/tests/kola

Oh definitely we should do that yep. But this approach is needed for the ostree case...unless we define conventions for that.

[jlebon]

Yeah, I think that makes sense. I.e. let's define tests/kola as the external tests dir. For config dirs like fedora-coreos-config, we check for this via ${cosaDir}/src/config/tests/kola. For the project being built, we just check tests/kola (i.e. the workspace). This matches e.g. make: true blindly building the code in the workspace.

For things that break that convention or for tests stored elsewhere, we can add an exttests: [] arg that override the default list? But that can come later.

[cgwalters]

Oh I like that yep!

[cgwalters]

coreos/coreos-assembler#1261

[cgwalters]

And reworked this per above discussion.

[jlebon]

I just did a minor fixup to this to avoid another round-trip. (Changed WORKSPACE to env.WORKSPACE and just spelled out the --exttest switch to be more explicit.)

Thanks!

[cgwalters]

I pushed 55bb2ae