Skip to content

[4.3] Rework prune#893

Closed
vrutkovs wants to merge 2 commits intocoreos:masterfrom
vrutkovs:4.3-prune
Closed

[4.3] Rework prune#893
vrutkovs wants to merge 2 commits intocoreos:masterfrom
vrutkovs:4.3-prune

Conversation

@vrutkovs
Copy link
Copy Markdown

@vrutkovs vrutkovs commented Nov 5, 2019

Cherrypick of #839 on 4.3

Vadim Rutkovsky added 2 commits November 5, 2019 14:58
* Split "insert_build" helper out of cmd-prune
* Rework cmd-prune in python
* Add prune tests
This subcommand cleans up unreferenced builds on remote location. 
Currently only s3 buckets are implemented
@vrutkovs vrutkovs requested review from ashcrow, cgwalters and jlebon and removed request for cgwalters November 5, 2019 13:59
@cgwalters
Copy link
Copy Markdown
Member

But this means we've now actually forked for 4.3...I'm going to aim to get RHCOS working with cosa master again today, then we can just fast forward to latest cosa master?

Let's really really try hard not to get into the fork situation again?

@vrutkovs
Copy link
Copy Markdown
Author

vrutkovs commented Nov 5, 2019

Oh, I thought branching is a standard process, not something we want to avoid

@ashcrow ashcrow requested review from arithx and removed request for ashcrow November 5, 2019 15:06
@arithx
Copy link
Copy Markdown
Contributor

arithx commented Nov 5, 2019

Should this be targeting the rhcos-4.3 branch instead of master?

@cgwalters
Copy link
Copy Markdown
Member

Oh, I thought branching is a standard process, not something we want to avoid

Per discussion on private chat, I think we definitely want tags (i.e. regular releases) - that's just a good idea. But branching can quickly become forking which is very problematic for everyone who needs to work on both OSes.

For 4.2, we did need to branch because 4.2 RHCOS needed Anaconda, but 4.3 dropped that.

Currently, the rhcos-4.3 branch is just effectively a tag.

What unifiying is blocking on is coreos/ignition-dracut#132

@vrutkovs
Copy link
Copy Markdown
Author

vrutkovs commented Nov 5, 2019

Agreed, tags seem to be a better idea. Closing this to avoid confusion

@vrutkovs vrutkovs closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants