s390x: build bare metal DASD image #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
requested changes
Sep 25, 2019
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
LGTM overall, just need to pacify shellcheck.
tuan-hoang1
commented
Sep 25, 2019
Contributor
Author
|
Goes along with : coreos/coreos-installer#61 |
jlebon
reviewed
Sep 25, 2019
tuan-hoang1
force-pushed
the
s390x-dasd
branch
from
2a9c072 to
86d6ab6
Compare
The block size of QEMU raw image used for ECKD DASD needs to be 4096. This is the interim solution for ECKD DASD. In the long terms, we would need to have a DASD raw image instead.
tuan-hoang1
force-pushed
the
s390x-dasd
branch
from
86d6ab6 to
01ba2fa
Compare
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block size of QEMU raw image used for ECKD DASD needs to be 4096.
This is the interim solution for ECKD DASD. In the long terms, we would
need to have a DASD raw image instead.