Conversation
Merged
ajeddeloh
approved these changes
Jun 21, 2019
Contributor
ajeddeloh
left a comment
ajeddeloh
left a comment
There was a problem hiding this comment.
LGTM with or with the suggested changes.
Member
You can have any color you want as long as it's black! |
In privileged mode, there is no `cache.qcow2` since we compose directly on the host. Teach the supermin goop to skip `mount` and `fstrim` in that case.
Only root can `chown` things. Though we're root in the supermin appliance, files we create on the 9p mount are all created with our uid, of course. Doing `chown -R` like this worked before because `chown`ing to yourself isn't an error. But now with the Anaconda removal work, we use the supermin path even when privileged. Except we don't have a `cache.qcow2`, so our root-owned cached (since rpm-ostree is still run as real root) was showing through the 9p mount, and `chown` was no longer a no-op and would of course fail.
Bash doesn't like using `-ne` for string comparisons:
[: x86_64: integer expression expected
We need to use `!=` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages.