Allow image.yaml to specify extra kernel args#525
Merged
dustymabe merged 1 commit intocoreos:masterfrom May 17, 2019
bgilbert:kargs
Merged
Allow image.yaml to specify extra kernel args#525dustymabe merged 1 commit intocoreos:masterfrom bgilbert:kargs
dustymabe merged 1 commit intocoreos:masterfrom
bgilbert:kargs
Conversation
Member
|
LGTM - testing now |
Member
|
works - I see this on a booted system: holding on merge for now until we resolve coreos/fedora-coreos-config#95 (comment) |
FCOS wants to disable SMT by default; RHCOS doesn't.
Contributor
Author
|
Updated. |
jlebon
approved these changes
May 17, 2019
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
LGTM! Will leave the final merge to @dustymabe.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCOS wants to disable SMT by default; RHCOS doesn't.
coreos/fedora-coreos-tracker#181