anaconda-cleanup: Remove /etc/resolv.conf#478
Merged
jlebon merged 1 commit intocoreos:masterfrom Apr 11, 2019
Merged
Conversation
bgilbert
approved these changes
Apr 11, 2019
Contributor
|
what already @bgilbert mentioned, other than that LGTM |
ashcrow
approved these changes
Apr 11, 2019
Member
|
LGTM! Will leave it open for now in case you wanted to address the nit. A more atomic option here would be to switch to a whitelist of files we actually do want from anaconda, and otherwise essentially |
Member
Author
Unfortunately...while I've said that about This also gets into coreos/fedora-coreos-config#39 |
This definitely shouldn't be in the image by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This definitely shouldn't be in the image by default.