cmdlib: Create overrides dir if there's an overlay#427
Merged
miabbott merged 2 commits intocoreos:masterfrom Mar 22, 2019
Merged
cmdlib: Create overrides dir if there's an overlay#427miabbott merged 2 commits intocoreos:masterfrom
miabbott merged 2 commits intocoreos:masterfrom
Conversation
We already defined this variable to the same value higher up at function scope.
Otherwise we'll error out if the user has no overrides. Regression from coreos#414.
Member
Author
|
An alternative approach here would be to create our own separate local repo for the overlay RPM so we don't use the same overrides dir that users interact with. I can do this if folks prefer. |
Member
Author
|
(This broke the FCOS pipeline. :( ) |
miabbott
approved these changes
Mar 22, 2019
Member
|
i wonder if we should create it as part of |
Contributor
I'd find this helpful - avoids the need to manually create it and makes it more visible, even if it's empty. I can make a quick PR to add this in. |
Member
Author
|
Sure, WFM!
Go for it! 👍 |
rfairley
pushed a commit
to rfairley/coreos-assembler
that referenced
this pull request
Mar 22, 2019
Create this directory upfront to eliminate an additional step of creating it manually when overriding RPMs locally. Originally brought up in coreos#427.
jlebon
pushed a commit
that referenced
this pull request
Mar 22, 2019
Create this directory upfront to eliminate an additional step of creating it manually when overriding RPMs locally. Originally brought up in #427.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we'll error out if the user has no overrides.
Regression from #414.