Skip to content

src/cmd-build: allow chcon to fail #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajeddeloh wants to merge 1 commit into from
Closed

src/cmd-build: allow chcon to fail #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmd-build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ for itype in "${IMAGE_TYPES[@]}"; do
/usr/lib/coreos-assembler/gf-oemid "$(pwd)"/"${img_base}" "$(pwd)"/"${img_qemu}" qemu
# Clear the MCS SELinux labels
# See https://github.com/coreos/coreos-assembler/issues/292
chcon -vl s0 "${img_qemu}"
chcon -vl s0 "${img_qemu}" || echo "chcon failed. This is expected if SELinux is not enabled"
Copy link
Member

@jlebon jlebon Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like:

if [[ $(getenforce || :) == Enforcing ]]; then
  chcon ...
fi

?

That way, we make sure we still fail if SELinux is enabled and we're missing perms or something.

# make a version-less symlink to have a stable path
# TODO: Remove this, things should be parsing the metadata
ln -s "${img_qemu}" "${name}"-qemu.qcow2
Expand Down