README: Use cosa in examples
#343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cgwalters since you had comments on this in the original README PR |
Member
|
LGTM - I think we'll be introducing some confusion by adding a new name but it should probably be worth it over time. |
miabbott
approved these changes
Feb 12, 2019
This allows for us to save some keystrokes. Also added cosa -> coreos-assembler symlink to make it support the "running inside the container" use case as well. Fixes #291
Member
Author
|
Thanks for the review.. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for us to save some keystrokes. Also added
cosa -> coreos-assembler symlink to make it support
the "running inside the container" use case as well.
Fixes #291