Add hack/Dockerfile, drop COREOS_ASSEMBLER_GIT
#3087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to using even more Go, the workflow of just bind mounting the source code will break more and more. (It has never worked for anything in mantle/) Let's document a more robust workflow that ensures that the Go code is recompiled.
jmarrero
reviewed
Sep 15, 2022
| @@ -0,0 +1,8 @@ | |||
| # Use this for quicker iteration on coros-assembler; from the toplevel run e.g.: | |||
Member
There was a problem hiding this comment.
coros-assembler --> coreos-assembler
Member
|
I'm sorry for not looking at this sooner. I'd like to not drop the existing workflow. I do have some local modifications to make things still work that I'd like to propose when I have time. |
Merged
Contributor
|
@dustymabe do you have kind of PoC for your alternative? |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to using even more Go, the workflow of just bind mounting the source code will break more and more.
(It has never worked for anything in mantle/)
Let's document a more robust workflow that ensures that the Go code is recompiled.