Skip to content

Conversation

@cgwalters
Copy link
Member

It's a huge dependency, and everything in schema/ gets
re-vendored again at the toplevel and in mantle.

The minio stuff is a dependency of gangplank which we're not
building right now.

Instead of minio, I want to make a push to use OCI artifacts
to store coreos-assembler metadata.

@dustymabe
Copy link
Member

Wow. I thought we had already dropped minio by stopping building gangplank. The diff is really hard to follow here because there are so many files. For my education, what exactly did you do here (i.e. the steps you took to get this diff)?

@cgwalters
Copy link
Member Author

Basically

$ cd schema
$ <write code changes to drop minio deps>
$ go mod tidy && go mod vendor
$ cd ../mantle
$ go mod tidy && go mod vendor

To review from the Github UI, you should see a file panel on the left. You can collapse the vendor/ directories - this will show just the changed files in schema/*.go.

@cgwalters
Copy link
Member Author

Now, I think what we really want to do is kill off the schema/ module, move the logic to the toplevel, and switch to have mantle/ vendor the toplevel.

@dustymabe
Copy link
Member

To review from the Github UI, you should see a file panel on the left. You can collapse the vendor/ directories - this will show just the changed files in schema/*.go.

cool. I trust you. Thanks for tracking this down. I wonder how much space savings we get because of this.

dustymabe
dustymabe previously approved these changes Sep 1, 2022
It's a huge dependency, and everything in schema/ gets
re-vendored *again* at the toplevel and in mantle.

The minio stuff is a dependency of gangplank which we're not
building right now.

Instead of minio, I want to make a push to use OCI artifacts
to store coreos-assembler metadata.
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters enabled auto-merge (rebase) September 1, 2022 18:44
@cgwalters cgwalters merged commit 1b4f1c9 into coreos:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants