Skip to content

main: Change /sys/fs/selinux handling to be a hard error #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustymabe merged 1 commit into from
Jul 6, 2022
Merged

main: Change /sys/fs/selinux handling to be a hard error #2960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/coreos-assembler
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,10 @@ if ! whoami &> /dev/null; then
fi
fi

# Ensure we've unshared our mount namespace so
# the later umount doesn't affect the host potentially
# https://github.com/containers/libpod/issues/1448
if [ -e /sys/fs/selinux/status ]; then
if [ -z "${coreos_assembler_unshared:-}" ]; then
exec sudo -E -- env coreos_assembler_unshared=1 unshare -m -- runuser -u "${USER}" -- "$0" "$@"
else
# Work around https://github.com/containers/libpod/issues/1448
# https://github.com/cgwalters/coretoolbox/blob/04e36894cdb912cd4d4c91b26436c57a2d96707d/src/coretoolbox.rs#L616
sudo mount --bind /usr/share/empty /sys/fs/selinux
fi
echo "error: /sys/fs/selinux appears to be mounted but should not be" 1>&2
exit 1
fi

cmd=${1:-}
Expand Down