schema: Add entry for base-oscontainer

[cgwalters]

For now, we need to support having the new format oscontainer in
meta.json.

Part of #2685
And see #2685 (comment)
in particular.

[cgwalters]

I was trying to follow in the footsteps of the kubevirt change in #2750
but I do not understand all the stuff around schemas. I see we have make schema-check
which starts out

.PHONY: schema-check
schema-check: DIGEST = $(shell sha256sum src/v1.json | awk '{print $$1}')
schema-check:
	# Are the JSON Schema copies synced with each other?
	diff -u src/v1.json schema/v1.json

And right there I have questions - like, why are there two files at all?

Then the schema is apparently copied again into both mantle and gangplank code? 🤯
This seems like it really wants #2821

[bgilbert]

Yeah, the multiple copies aren't great. The test is there because our current architecture requires them, and we kept breaking things by getting the copies out of sync.

You'll need to revendor both gangplank and mantle.

[cgwalters]

The test is there because our current architecture requires them

Comments on #2821 appreciated 😄

You'll need to revendor both gangplank and mantle.

Ahhh! Now I see the

replace (
	github.com/coreos/coreos-assembler-schema => ../schema

bit and I understand how this works.

[cgwalters]

OK, tested this fully now.

[cgwalters]

/override ci/prow/rhcos

[openshift-ci]

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos

Details

In response to this:

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

/override ci/prow/rhcos

[openshift-ci]

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos

Details

In response to this:

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlebon]

Bikeshed: should this be base-oscontainer instead for consistency with the existing oscontainer?

Or maybe native-oscontainer to better highlight the difference between the two.

[cgwalters]

OK renamed to base-oscontainer.

[cgwalters]

Note we should change the FCOS pipeline to use this here https://github.com/coreos/fedora-coreos-pipeline/blob/515ae3806f70dc3ede18c9a885bade2d0cce3d2f/jobs/release.Jenkinsfile#L132

Also, this is going require changing the RHCOS pipeline to also do:

• push to S3
• push container
• push to S3