src/cmd*: use os.path.join() where appropriate #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcrow
approved these changes
Jan 8, 2019
|
Adding @jlebon as a reviewer as well so we get two sets of eyes. |
|
Yup, looks nice! |
dustymabe
reviewed
Jan 8, 2019
| # SHA256 for uncompressed image was already calculated during 'build' | ||
| img['uncompressed-sha256'] = img['sha256'] | ||
| with open(tmpfile, 'wb') as f: | ||
| run_verbose(['gzip', '-c', f'builds/{build}/{file}'], stdout=f) | ||
| run_verbose(['gzip', '-c', filepath], stdout=f) |
There was a problem hiding this comment.
looks like we should have been using filepath here all along?
There was a problem hiding this comment.
It wasn't wrong if that's what you mean. But it was indeed repeating the same string again. :)
There was a problem hiding this comment.
Yeah, I made some minor DRY improvements where I could
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #270
This changes all the places where we muck with paths to use
os.path.join(). Hopefully this is start of some coding standards asdiscussed in #271.