kola: Move kola-denylist.yaml related sugar from cmd-kola to kola #2296
Conversation
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
Nice work @saqibali-2k. A few comments inline
|
For your first commit message I'd break it up slightly: We try to have a single title line, then a blank line, then a description. |
Thanks for pointing that out! I'll try to follow that format from now on. |
saqibali-2k
force-pushed
the
kola-denylist-transfer-main
branch
2 times, most recently
from
a660ddc to
99e00be
Compare
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
LGTM
A few optional suggestions (comments).
saqibali-2k
force-pushed
the
kola-denylist-transfer-main
branch
from
99e00be to
2f1a501
Compare
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
This looks really good, thanks a lot for tackling this! A few nits, but overall LGTM!
Added functionality to parse deny listed tests from a `kola-denylist.yaml` file if found. This moves the functionality from cmd-kola (python) into kola proper (golang).
…in kola-denylist.yaml are skipped
saqibali-2k
force-pushed
the
kola-denylist-transfer-main
branch
from
2f1a501 to
234b9fc
Compare
|
/lgtm |
|
/override ci/prow/sanity |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/sanity DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
overriding the shellcheck CI issue that's been plaguing us. |
3 participants
Before introducing more functionality to deny listed tests, we want to have the deny list logic contained in a single location (kola).