-
Notifications
You must be signed in to change notification settings - Fork 187
kola/tests: Enable Tang tests for ppc64le and aarch64 #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @jcajka |
|
/approve Title should probably read "Enable Tang tests ..." instead since that's what these tests are primarily testing (though some use TPM2 as well). TPM2-only tests live at https://github.com/coreos/fedora-coreos-config/blob/testing-devel/tests/kola/root-reprovision/luks/test.sh and https://github.com/openshift/os/blob/master/tests/kola/luks/tpm/test.sh -- I think we can expand the architectures there too, right? |
Ah..yes those tests can be enabled as well..let me test it and then i will enable those too. Thanks for pointing those out. |
With the move to f33, TPM is supported in qemu for ppc64le and aarch64. s390x does not support a TPM backend, so that is still disabled. Had to adjust memory for aarch64 because it also uses 64K pages.
Excluding aarch64 from upgrade test because it has no official release for rhcos yet.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlebon addressed the comments. sorry i lost track of this. should be good now! |
With the move to f33, TPM is supported in qemu for ppc64le and aarch64. s390x does not support a
TPM backend, so that is still disabled. Had to adjust memory for aarch64 because it also uses 64K
pages.