Skip to content

Conversation

@Prashanth684
Copy link
Contributor

With the move to f33, TPM is supported in qemu for ppc64le and aarch64. s390x does not support a
TPM backend, so that is still disabled. Had to adjust memory for aarch64 because it also uses 64K
pages.

@Prashanth684
Copy link
Contributor Author

cc @jcajka

@jlebon
Copy link
Member

jlebon commented Dec 8, 2020

/approve

Title should probably read "Enable Tang tests ..." instead since that's what these tests are primarily testing (though some use TPM2 as well). TPM2-only tests live at https://github.com/coreos/fedora-coreos-config/blob/testing-devel/tests/kola/root-reprovision/luks/test.sh and https://github.com/openshift/os/blob/master/tests/kola/luks/tpm/test.sh -- I think we can expand the architectures there too, right?

@Prashanth684 Prashanth684 changed the title kola/tests: Enable TPM tests for ppc64le and aarch64 kola/tests: Enable Tang tests for ppc64le and aarch64 Dec 9, 2020
@Prashanth684
Copy link
Contributor Author

/approve

Title should probably read "Enable Tang tests ..." instead since that's what these tests are primarily testing (though some use TPM2 as well). TPM2-only tests live at https://github.com/coreos/fedora-coreos-config/blob/testing-devel/tests/kola/root-reprovision/luks/test.sh and https://github.com/openshift/os/blob/master/tests/kola/luks/tpm/test.sh -- I think we can expand the architectures there too, right?

Ah..yes those tests can be enabled as well..let me test it and then i will enable those too. Thanks for pointing those out.

With the move to f33, TPM is supported in qemu for ppc64le and aarch64. s390x does not support a
TPM backend, so that is still disabled. Had to adjust memory for aarch64 because it also uses 64K
pages.
Excluding aarch64 from upgrade test because it has no official release for rhcos yet.
@jlebon
Copy link
Member

jlebon commented Dec 15, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prashanth684
Copy link
Contributor Author

@jlebon addressed the comments. sorry i lost track of this. should be good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants