docs/kola: mention external tests are preferred#1791
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Oct 15, 2020
Merged
docs/kola: mention external tests are preferred#1791openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
sohankunkerkar
approved these changes
Oct 14, 2020
cgwalters
approved these changes
Oct 14, 2020
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I'm on board personally yep.
All else equal, we prefer test contributors to use the external test model where tests can live alongside the OS definition over adding more "native" kola tests. See previous discussions about this in coreos#1273.
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, mike-nguyen, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All else equal, we prefer test contributors to use the external test
model where tests can live alongside the OS definition over adding more
"native" kola tests.
See previous discussions about this in
#1273.