testiso: Support pxe-install test on aarch64 #1700
Conversation
This adds support for running pxe-install test on aarch64. In the process of doing this , I discovered that boot once is not supported and the boot order had to be changed after installation (unlike s390x where the disk is always checked first). This got me back to using QMP again and it works pretty well and is pretty convenient to change the boot order of a running system One follow up would be to try to use QMP in general for injecting bootindex for pxe and iso test cases and do away with adding the primary disk for testiso altogether.
Prashanth684
force-pushed
the
aarch64-tests
branch
from
e04c8c6 to
cb35969
Compare
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Nice, this looks really great! Using QMP will help us with other things in the future too.
| return | ||
| } | ||
| // switch the boot order here, we are well into the installation process. Only used for PXE test now | ||
| if line == liveOKSignal { |
There was a problem hiding this comment.
This is completely fine for now though I think the functionality would better live in metal.go - that's intending to be the abstraction over performing an install, whereas testiso.go is just about testing.
Concretely eventually we want kola run -p pxe-install podman.* and cosa run -p pxe-install which would run tests/give you ssh after doing a PXE install, rather than how testiso.go is hardcoded to just a sanity check.
Fine for now though.
There was a problem hiding this comment.
i agree. I was going to do some refactoring around this and try to move everything to metal. But - for this particular case, is there a better place in metal.go to figure out that we have started with the installation process and can switch the boot order?
There was a problem hiding this comment.
It's totally fine as is, feel free to just add a comment for this and we can do it later. Given the size of change here I'd prefer to get it in than force you into rebasing later etc.
But if you want to take a quick shot at it I think what metal.go should do is inject its own Ignition to write to a separate virtio channel, distinct from what testiso.go is doing.
There was a problem hiding this comment.
ah..ok got it ..yes..i'll try to tackle that separately :) i'll stick with these changes for now and probably move some of the QMP bits to its own package.
|
Since this is a big PR leaving open for a bit for others to review! |
Prashanth684
changed the title
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
Other than the current conversation, this looks fine to me.
/approve
Happy to relook after the WIP is lifted.
move the qmp related methods to a separate file to make it cleaner
Prashanth684
changed the title
|
Lifting WIP after some changes and sufficient testing. |
|
@darkmuggle , anybody - could i get an lgtm ? |
|
Very cool stuff! This had two approvals already, so |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, darkmuggle, jlebon, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a follow up to coreos#1700 also support iso tests on aarch64
As a follow up to coreos#1700 also support iso tests on aarch64
As a follow up to #1700 also support iso tests on aarch64
Following up on comment in coreos#1700 to split the functionality to trigger the boot order switch to metal.go making it generic.
Following up on comment in #1700 to split the functionality to trigger the boot order switch to metal.go making it generic.
6 participants
This adds support for running pxe-install test on aarch64. In the process of doing this , I discovered
that boot once is not supported and the boot order had to be changed after installation (unlike s390x where
the disk is always checked first). This got me back to using QMP again and it works pretty well and is pretty
convenient to change the boot order of a running system
One follow up would be to try to use QMP in general for injecting bootindex for pxe and iso test cases and do
away with adding the primary disk for testiso altogether.