kola: add minMemory in kola.json (external tests)#1651
Merged
openshift-merge-robot merged 2 commits intocoreos:masterfrom Aug 11, 2020
Merged
kola: add minMemory in kola.json (external tests)#1651openshift-merge-robot merged 2 commits intocoreos:masterfrom
openshift-merge-robot merged 2 commits intocoreos:masterfrom
Conversation
Prep for next patch.
For the root reprovisioning work, we need to be able to temporarily save the rootfs into RAM. This means we need at least 4G of RAM. Add a new `minMemory` field which tells the platform to make sure the machine provisioned has at least that amount of memory. On QEMU, this directly controls the memory of the machine. On cloud platforms, it would affect the instance type to use. But for now, we only actually handle this field on QEMU.
ashcrow
approved these changes
Aug 11, 2020
darkmuggle
approved these changes
Aug 11, 2020
Contributor
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
/lgtm
This seems cleaner to me. I like the switch to using a MachineOption over the additionalDisks.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, darkmuggle, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
I'm ok with this but I think what we should do instead in the future is support something like openstack/aws instance sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the root reprovisioning work, we need to be able to temporarily save
the rootfs into RAM. This means we need at least 4G of RAM.
Add a new
minMemoryfield which tells the platform to make sure themachine provisioned has at least that amount of memory. On QEMU, this
directly controls the memory of the machine. On cloud platforms, it
would affect the instance type to use. But for now, we only actually
handle this field on QEMU.